Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API in tutorials #204

Merged
merged 1 commit into from Feb 9, 2021
Merged

Update API in tutorials #204

merged 1 commit into from Feb 9, 2021

Conversation

jeff-hernandez
Copy link
Collaborator

@jeff-hernandez jeff-hernandez commented Feb 9, 2021

The latest versions in the doc requirements introduced breaking API changes in the tutorials. This PR updates the API to the latest changes.

@jeff-hernandez jeff-hernandez added the documentation Improvements or additions to documentation label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #204 (f218dd7) into main (4003974) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1259      1259           
=========================================
  Hits          1259      1259           

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

By the way, when we finish the update of Woodwork to use the accessor approach, and EvalML has updated to use that, you should be able to revert this back to the previous code. Part of the reason we are making that update to Woodwork is so that things like this don't break...

@jeff-hernandez jeff-hernandez merged commit e3672bb into main Feb 9, 2021
@jeff-hernandez jeff-hernandez deleted the api_changes branch February 9, 2021 19:41
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants