Skip to content

Add parameter for maximum data - #216

Merged
jeff-hernandez merged 4 commits into
mainfrom
maximum_data
May 4, 2021
Merged

jeff-hernandez merged 4 commits into
mainfrom
maximum_data

Conversation

@jeff-hernandez

Copy link
Copy Markdown
Contributor

Closes #213 by adding a maximum_data parameter to control when the label search should stop. You can use this parameter to generate year-to-date labels.

lt = lm.search(
  ...
  minimum_data='2021-01-01',
  maximum_data='2021-05-03',
  drop_empty=False,
)

@codecov

codecov Bot commented May 3, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #216 (bfe067e) into main (cd59d71) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1259      1270   +11     
=========================================
+ Hits          1259      1270   +11     
Impacted Files Coverage Δ
composeml/data_slice/extension.py 100.00% <100.00%> (ø)
composeml/data_slice/generator.py 100.00% <100.00%> (ø)
composeml/label_maker.py 100.00% <100.00%> (ø)
composeml/tests/test_label_maker.py 100.00% <100.00%> (ø)

@jeff-hernandez
jeff-hernandez marked this pull request as ready for review May 3, 2021 21:31
@gsheni
gsheni requested a review from rwedge May 3, 2021 21:33
@rwedge

rwedge commented May 4, 2021

Copy link
Copy Markdown
Contributor

Lets update the changelog

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez
jeff-hernandez merged commit 7028876 into main May 4, 2021
@jeff-hernandez
jeff-hernandez deleted the maximum_data branch May 4, 2021 18:49
@jeff-hernandez jeff-hernandez mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to Add Complete Time Range

2 participants