Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use new Featuretools API and latest release of EvalML #275

Merged
merged 8 commits into from
Jan 19, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Closes #272
Closes #242

Updates the docs examples to use the new Featuretools API for creating and entityset and running dfs. Also updates docs requirements for Featuretools and EvalML.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2022

CLA assistant check
All committers have signed the CLA.

@thehomebrewnerd thehomebrewnerd self-assigned this Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #275 (83049bb) into main (7d79810) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          28       28           
  Lines        1324     1324           
=======================================
  Hits         1323     1323           
  Misses          1        1           
Impacted Files Coverage Δ
composeml/tests/test_featuretools.py 100.00% <ø> (ø)

jeff-hernandez
jeff-hernandez previously approved these changes Jan 19, 2022
Copy link
Collaborator

@jeff-hernandez jeff-hernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-hernandez
Copy link
Collaborator

Just one thing: can we make the note smaller or possibly markdown quote?
Screen Shot 2022-01-19 at 1 05 09 PM

@thehomebrewnerd
Copy link
Contributor Author

Just one thing: can we make the note smaller or possibly markdown quote? Screen Shot 2022-01-19 at 1 05 09 PM

Yeah, I just saw that as well as I was looking over things. I'll clean that up.

@gsheni
Copy link
Contributor

gsheni commented Jan 19, 2022

Screen Shot 2022-01-19 at 2 25 23 PM

Docs look good now.

@thehomebrewnerd thehomebrewnerd merged commit f10f572 into main Jan 19, 2022
@thehomebrewnerd thehomebrewnerd deleted the update-examples branch January 19, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support evalml v0.41.0 Update doc tutorials after Woodwork integration with Featuretools
4 participants