Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename target_entity to target_dataframe_name #276

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

Closes #241

Renames target_entity to target_dataframe_name to be consistent with Featuretools terminology.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #276 (84b30de) into main (7f2e039) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          28       28           
  Lines        1324     1324           
=======================================
  Hits         1323     1323           
  Misses          1        1           
Impacted Files Coverage Δ
composeml/conftest.py 100.00% <ø> (ø)
composeml/tests/test_featuretools.py 100.00% <ø> (ø)
composeml/tests/test_label_maker.py 100.00% <ø> (ø)
composeml/tests/test_label_serialization.py 100.00% <ø> (ø)
composeml/tests/test_label_times.py 100.00% <ø> (ø)
composeml/label_maker.py 100.00% <100.00%> (ø)
composeml/label_times/description.py 100.00% <100.00%> (ø)
composeml/label_times/object.py 100.00% <100.00%> (ø)
composeml/tests/test_data_slice/test_extension.py 100.00% <100.00%> (ø)
...mposeml/tests/test_label_transforms/test_sample.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@jeff-hernandez jeff-hernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehomebrewnerd thehomebrewnerd merged commit 8c7b336 into main Jan 19, 2022
@thehomebrewnerd thehomebrewnerd deleted the rename-entity branch January 19, 2022 22:18
This was referenced Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace target entity with target dataframe
3 participants