Skip to content

Transition to pyproject.toml and setup.cfg #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsheni merged 34 commits into from
Apr 5, 2022
Merged

Transition to pyproject.toml and setup.cfg #310

gsheni merged 34 commits into from
Apr 5, 2022

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 5, 2022 •
edited
Loading

@gsheni gsheni self-assigned this Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #310 (95a06b2) into main (d8cda66) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        29    +1     
  Lines         1330      1333    +3     
=========================================
+ Hits          1330      1333    +3
Impacted Files Coverage Δ
composeml/__init__.py 100.00% <100.00%> (ø)
composeml/tests/test_version.py 100.00% <100.00%> (ø)

thehomebrewnerd
thehomebrewnerd previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good - left a few comments on some minor things if you want to update, but nothing that is critical to fix.

gsheni
gsheni commented Apr 5, 2022
View reviewed changes
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
@gsheni gsheni enabled auto-merge (squash) April 5, 2022 19:24
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
gsheni
gsheni commented Apr 5, 2022
View reviewed changes
@gsheni gsheni merged commit 24c24e2 into main Apr 5, 2022
@gsheni gsheni deleted the pyprojectoml branch April 5, 2022 20:23
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 12, 2022
Merged
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff-hernandez jeff-hernandez Awaiting requested review from jeff-hernandez

1 more reviewer

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transition Compose to use pyproject.toml and setup.cfg (moving away from setup.py)

3 participants

@gsheni @thehomebrewnerd