Add create feedstock PR workflow#346
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 1333 1333
=========================================
Hits 1333 1333 |
gsheni
commented
Nov 3, 2022
| Future Release | ||
| ============== | ||
| * Enhancements | ||
| * Add create feedstock PR workflow (:pr:`346`) |
Contributor
There was a problem hiding this comment.
Minor nitpick, but should this be somewhere else, like Testing Changes since this isn't an enhancement a Compose user would see? I have tended to think of Enhancements as user-facing improvements, but not sure that is the right way to look at it.
| with: | ||
| project: "compose" | ||
| pypi_version: ${{ github.event.inputs.version }} | ||
| project_metadata_filepath: "composeml/pyproject.toml" |
Contributor
There was a problem hiding this comment.
Should this be compose or composeml here? Not exactly clear to me which we should use, but thought maybe since we used compose on L18, it should also be compose here?
gsheni
commented
Nov 8, 2022
thehomebrewnerd
approved these changes
Nov 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.