Skip to content

Handle categorical target with unused categories #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

Closes #274

Removes any unused categories in a categorical target during lm.search to avoid identifying target groups that contain no data.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@e0d2f90). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main      #349   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        29           
  Lines           ?      1341           
  Branches        ?         0           
========================================
  Hits            ?      1341           
  Misses          ?         0           
  Partials        ?         0           
Impacted Files Coverage Δ
composeml/label_maker.py 100.00% <100.00%> (ø)
composeml/tests/test_label_maker.py 100.00% <100.00%> (ø)

@thehomebrewnerd thehomebrewnerd merged commit d60452a into main Nov 22, 2022
@thehomebrewnerd thehomebrewnerd deleted the issue-274-empty-target-groups branch November 22, 2022 15:20
@thehomebrewnerd thehomebrewnerd self-assigned this Nov 30, 2022
@gsheni gsheni mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty target groups from category dtypes
2 participants