Transition to pure pyproject.toml for project metadata #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2022 17:33
added 2 commits
November 22, 2022 17:35
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 28 -1
Lines 1341 1335 -6
=========================================
- Hits 1341 1335 -6
|
gsheni
requested review from
thehomebrewnerd,
dvreed77,
rwedge,
jeff-hernandez,
ozzieD,
sbadithe and
tamargrey
gsheni
changed the title
docs/source/release_notes.rst
Outdated
| @@ -4,6 +4,7 @@ Release Notes | |||
| Future Release | |||
| ============== | |||
| * Enhancements | |||
| * Transition to pure pyproject.toml for project metadata (:pr:`351`) | |||
There was a problem hiding this comment.
Enhancement or change?
| @@ -13,7 +13,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest] | |||
| python_version: ["3.8", "3.9", "3.10"] | |||
| python_version: ["3.8", "3.9", "3.10", "3.11"] | |||
There was a problem hiding this comment.
If we are going to support 3.11, shouldn't we also run all our unit tests with 3.11, not just the install test?
pyproject.toml
Outdated
| "scikit-learn >= 0.20.0, !=0.22", | ||
| ] | ||
| complete = [ | ||
| "featuretools[updater]", |
There was a problem hiding this comment.
featuretools -> compose
| docs = [ | ||
| "evalml >= 0.45.0" | ||
| ] | ||
| dev = [ |
There was a problem hiding this comment.
Previously the dev requirements also included the test requirements. Should we also add compose[test] in this section?
ozzieD
approved these changes
Nov 23, 2022
thehomebrewnerd
approved these changes
Nov 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.