Skip to content

Delete MANIFEST.in and .coveragerc from root directory#359

Merged
gsheni merged 20 commits intomainfrom
remove_mainfest
Jan 6, 2023
Merged

Delete MANIFEST.in and .coveragerc from root directory#359
gsheni merged 20 commits intomainfrom
remove_mainfest

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented Jan 3, 2023 •
edited
Loading

  • Also move tests up one directory, and remove them from the released wheel + tar.gz file

@gsheni gsheni changed the title Delete MANIFEST.in Delete MANIFEST.in from root directory Jan 3, 2023
@gsheni gsheni self-assigned this Jan 3, 2023
@gsheni gsheni requested a review from thehomebrewnerd January 3, 2023 23:01
@gsheni gsheni changed the title Delete MANIFEST.in from root directory Delete MANIFEST.in and .coveragerc from root directory Jan 3, 2023
gsheni
gsheni commented Jan 3, 2023
View reviewed changes
thehomebrewnerd
thehomebrewnerd reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latest dependency checks are still trying to use the deleted .coveragerc file:

compose/.github/workflows/unit_tests_with_latest_deps.yml

Line 38 in d7b5921

pytest composeml/ -n 2 --cov=composeml --cov-config=../.coveragerc

@gsheni gsheni requested a review from thehomebrewnerd January 5, 2023 16:02
thehomebrewnerd
thehomebrewnerd previously approved these changes Jan 5, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #359 (4b1ecd6) into main (f869e24) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1339      1339           
=========================================
  Hits          1339      1339

@gsheni gsheni requested a review from thehomebrewnerd January 5, 2023 23:02
gsheni
gsheni commented Jan 5, 2023
View reviewed changes
gsheni
gsheni commented Jan 5, 2023
View reviewed changes
@gsheni gsheni merged commit 2fefec8 into main Jan 6, 2023
@gsheni gsheni deleted the remove_mainfest branch January 6, 2023 14:14
@gsheni gsheni mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsheni @thehomebrewnerd