Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to check all test files are included in package #1031

Closed
freddyaboulton opened this issue Aug 6, 2020 · 1 comment · Fixed by #1054
Closed

Add CI job to check all test files are included in package #1031

freddyaboulton opened this issue Aug 6, 2020 · 1 comment · Fixed by #1054
Labels
enhancement An improvement to an existing feature. testing Issues related to testing.
Milestone

Comments

@freddyaboulton
Copy link
Contributor

We saw in #1024 that we were not adding test files to the pypi package. This makes it impossible to test evalml during conda package creation and it also doesn't let users test the package once they pip install it (when tests are included in the package, users can test it with pytest --pyargs evalml).

Going forward, we want to make sure that all current and future test files are included in the package. This issues tracks works to create a CI Job to check that every test file is included in the package.

I think checking that every directory with the name test_ has an init file would suffice but that is not the only solution.

@freddyaboulton freddyaboulton added enhancement An improvement to an existing feature. testing Issues related to testing. labels Aug 6, 2020
@dsherry dsherry changed the title Add CI job to check all test files are included in the package Add CI job to check all test files are included in package Aug 11, 2020
@dsherry dsherry added this to the September 2020 milestone Aug 11, 2020
@dsherry
Copy link
Contributor

dsherry commented Aug 11, 2020

Agreed @freddyaboulton , let's add CI coverage for this.

I like your idea of looking for every directory with name test_ under evalml/tests/ and making sure each has a file called __init__.py. I think that would do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature. testing Issues related to testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants