Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support training-only components in ComponentGraph #2681

Closed
angela97lin opened this issue Aug 23, 2021 · 1 comment · Fixed by #2776
Closed

Support training-only components in ComponentGraph #2681

angela97lin opened this issue Aug 23, 2021 · 1 comment · Fixed by #2776
Assignees
Labels
enhancement An improvement to an existing feature.

Comments

@angela97lin
Copy link
Contributor

Right now, we support samplers as training-only components by checking if the component is a sampler component and not taking any action if so:

elif isinstance(component_instance, BaseSampler):

Once we add other components that are train-only (ex: drop rows), we should verify our behavior holds for other components by updating this line to be more general.

@dsherry
Copy link
Contributor

dsherry commented Aug 25, 2021

One idea: tagging. All training-only components get static attribute TRAINING_ONLY, and we update this elif to check that static tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants