Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate utils to avoid circular imports #911

Closed
freddyaboulton opened this issue Jul 6, 2020 · 1 comment · Fixed by #934
Closed

Consolidate utils to avoid circular imports #911

freddyaboulton opened this issue Jul 6, 2020 · 1 comment · Fixed by #934
Assignees
Milestone

Comments

@freddyaboulton
Copy link
Contributor

In PR #898, we ran into circular imports between model_family/utils and pipelines/utils. The issue is that list_model_families should not be included in model_family since it is used to construct pipelines and as such needs knowledge of the all the available estimators.

This issue tracks work related to moving list_model_families back to pipelines but also investigating if there are better ways of organizing our utils to prevent cyclic imports.

@freddyaboulton freddyaboulton added this to the July 2020 milestone Jul 6, 2020
@angela97lin
Copy link
Contributor

Ah, I remember this is something I ran into--going to try to tackle this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants