-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error if all pipelines produce nan scores in automl #1015
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 181 181
Lines 9597 9628 +31
=======================================
+ Hits 9584 9615 +31
Misses 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @angela97lin Looks great! I have a question about the implementation. I think we should be resetting current_batch_pipeline_scores
after each batch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin I think this "was-batch-all-nan" check would fit better in IterativeAlgorithm
, right? You could basically adopt the same approach there as you took here, save the scores in a list and raise an error when next_batch
is called. Happy to talk more about that if you'd like.
That said, your implementation works great and satisfies the requirements, so its fine to merge from my perspective.
@dsherry I think you're right! I tried it but realized that |
@angela97lin ok cool, thanks for looking into it! I suppose we could either not mention the objective in the exception or modify the iterative algo further, but sounds good to me for the time being 👍 |
Closes #922 by checking if all pipelines in a batch return a score of NaN and stopping search if that is the case.