Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds needs_fitting property to ComponentBase #1044

Merged
merged 10 commits into from Aug 13, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Aug 11, 2020

Closes #989

@angela97lin angela97lin added this to the August 2020 milestone Aug 11, 2020
@angela97lin angela97lin self-assigned this Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1044 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1044   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         183      183           
  Lines       10147    10156    +9     
=======================================
+ Hits        10138    10147    +9     
  Misses          9        9           
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.00% <100.00%> (ø)
...elines/components/transformers/column_selectors.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py 99.60% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8c71a...1088a1b. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Aug 12, 2020
@angela97lin angela97lin requested review from dsherry, jeremyliweishih, freddyaboulton and eccabay and removed request for dsherry and jeremyliweishih Aug 12, 2020
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM other than one comment!

evalml/pipelines/components/component_base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

👏 !

evalml/pipelines/components/component_base.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit 12be7f4 into main Aug 13, 2020
@dsherry dsherry mentioned this pull request Aug 25, 2020
@angela97lin angela97lin deleted the 989_needs_fitting branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add needs_fitting as a field for components
3 participants