Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds needs_fitting property to ComponentBase #1044

Merged
merged 10 commits into from
Aug 13, 2020
Merged

Adds needs_fitting property to ComponentBase #1044

merged 10 commits into from
Aug 13, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #989

@angela97lin angela97lin added this to the August 2020 milestone Aug 11, 2020
@angela97lin angela97lin self-assigned this Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #1044 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1044   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         183      183           
  Lines       10147    10156    +9     
=======================================
+ Hits        10138    10147    +9     
  Misses          9        9
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.00% <100.00%> (ø)
...elines/components/transformers/column_selectors.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py 99.60% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8c71a...1088a1b. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review August 12, 2020 17:51
jeremyliweishih
jeremyliweishih approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one comment!

evalml/pipelines/components/component_base.py Outdated Show resolved Hide resolved
dsherry
dsherry approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 !

evalml/pipelines/components/component_base.py Outdated Show resolved Hide resolved
evalml/tests/component_tests/test_components.py Show resolved Hide resolved
@angela97lin angela97lin merged commit 12be7f4 into main Aug 13, 2020
@dsherry dsherry mentioned this pull request Aug 25, 2020
Merged
@angela97lin angela97lin deleted the 989_needs_fitting branch September 24, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.

Add needs_fitting as a field for components
3 participants
@angela97lin @dsherry @jeremyliweishih