Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release notes #1103

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Fix release notes #1103

merged 3 commits into from
Aug 26, 2020

Conversation

bchen1116
Copy link
Contributor

Fix Wording

Change feature_threshold to importance_threshold in release notes

@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #1103 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         192      192           
  Lines       10751    10751           
=======================================
  Hits        10742    10742           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc8888...3df7092. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review August 25, 2020 22:41
@bchen1116 bchen1116 requested a review from dsherry August 25, 2020 22:41
dsherry
dsherry approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bchen1116 bchen1116 merged commit 037a6c9 into main Aug 26, 2020
@bchen1116 bchen1116 deleted the bc_869_feature_fix branch September 10, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@bchen1116 bchen1116

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchen1116 @dsherry