Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding step for how to publish latest package to conda-forge. #1118

Merged
merged 3 commits into from Aug 27, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Aug 27, 2020

Pull Request Description

Fixes #1106.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1118 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         194      194           
  Lines       10957    10957           
=======================================
  Hits        10948    10948           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2691cb3...b2f1976. Read the comment docs.

@@ -182,3 +182,26 @@ pip freeze | grep evalml
```

Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv.

## 6. Publish Our New Conda Package
Copy link
Contributor Author

@freddyaboulton freddyaboulton Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt it was better to leave this as the last step since it happens after the package has been published to PyPi.

Copy link
Collaborator

@dsherry dsherry Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep ok. I see you have "verify" text at the end here too.

@freddyaboulton freddyaboulton marked this pull request as ready for review Aug 27, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Thanks!

@@ -182,3 +182,26 @@ pip freeze | grep evalml
```

Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv.

## 6. Publish Our New Conda Package
Copy link
Collaborator

@dsherry dsherry Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep ok. I see you have "verify" text at the end here too.

## 6. Publish Our New Conda Package

A couple of hours after you publish the GitHub release, a bot will open a PR to our [feedstock](https://github.com/conda-forge/evalml-core-feedstock) that automatically
bumps the recipe to use the latest version of the package.
Copy link
Collaborator

@dsherry dsherry Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah fancy


If you had to modify the recipe in Step 1, then make those changes and push to the bot's PR. For help on how to push changes to the
bot's PR please read this [document.](https://conda-forge.org/docs/maintainer/updating_pkgs.html#pushing-to-regro-cf-autotick-bot-branch)
If you did not have to modify the recipe in Step 1, the bot's PR should be good to merge as-is.
Copy link
Collaborator

@dsherry dsherry Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what case do you have to modify the recipe? If deps need to be updated, new packages added? Could be nice to explain this

Copy link
Contributor Author

@freddyaboulton freddyaboulton Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@angela97lin angela97lin left a comment

Sweet, LGTM!

@freddyaboulton freddyaboulton force-pushed the 1106-release-instructions-for-conda branch from 0ea8f2d to b2f1976 Compare Aug 27, 2020
@freddyaboulton freddyaboulton merged commit 9e00e0f into main Aug 27, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the 1106-release-instructions-for-conda branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release process doc: add instructions for making conda release
3 participants