-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding step for how to publish latest package to conda-forge. #1118
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 194 194
Lines 10957 10957
=======================================
Hits 10948 10948
Misses 9 9 Continue to review full report at Codecov.
|
@@ -182,3 +182,26 @@ pip freeze | grep evalml | |||
``` | |||
|
|||
Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv. | |||
|
|||
## 6. Publish Our New Conda Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt it was better to leave this as the last step since it happens after the package has been published to PyPi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yep ok. I see you have "verify" text at the end here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -182,3 +182,26 @@ pip freeze | grep evalml | |||
``` | |||
|
|||
Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv. | |||
|
|||
## 6. Publish Our New Conda Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yep ok. I see you have "verify" text at the end here too.
## 6. Publish Our New Conda Package | ||
|
||
A couple of hours after you publish the GitHub release, a bot will open a PR to our [feedstock](https://github.com/conda-forge/evalml-core-feedstock) that automatically | ||
bumps the recipe to use the latest version of the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah fancy
|
||
If you had to modify the recipe in Step 1, then make those changes and push to the bot's PR. For help on how to push changes to the | ||
bot's PR please read this [document.](https://conda-forge.org/docs/maintainer/updating_pkgs.html#pushing-to-regro-cf-autotick-bot-branch) | ||
If you did not have to modify the recipe in Step 1, the bot's PR should be good to merge as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what case do you have to modify the recipe? If deps need to be updated, new packages added? Could be nice to explain this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, LGTM!
0ea8f2d
to
b2f1976
Compare
Pull Request Description
Fixes #1106.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.