-
Notifications
You must be signed in to change notification settings - Fork 89
Add Label Encoder to LightGBM #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 195 195
Lines 11515 11554 +39
=======================================
+ Hits 11505 11544 +39
Misses 10 10
Continue to review full report at Codecov.
|
Changed implementation to encode the labels if they weren't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @bchen1116 - just a couple small comments but nothing blocking.
evalml/pipelines/components/estimators/classifiers/lightgbm_classifier.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/estimators/classifiers/lightgbm_classifier.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/estimators/classifiers/lightgbm_classifier.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 Looks good to me!
Fix #1109
Add label Encoder for Binary classification case for LightGBM.