Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap mapping of breast cancer targets for model_understanding.ipynb #1170

Merged
merged 5 commits into from
Sep 15, 2020

Conversation

angela97lin
Copy link
Contributor

Swap mapping of breast cancer targets for model_understanding.ipynb to align with .classes_

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1170 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         197      197           
  Lines       11705    11705           
=======================================
  Hits        11695    11695           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f6767...38a1897. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Thanks for following-up! I think this is good to merge once we select the "malignant" column from the probabilities dataframe for the precision-recall and ROC plots.

docs/source/user_guide/model_understanding.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 51941c1 into main Sep 15, 2020
@angela97lin angela97lin deleted the ange_swap_mal_ben_mapping branch September 15, 2020 15:59
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants