Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes check for dependency updates PR #1172

Merged
merged 7 commits into from Sep 15, 2020
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Sep 15, 2020

Fixes #1148.

This PR:

#!/bin/sh -eo pipefail
if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then
  echo This is a release PR;
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
  echo This is a dependency update PR;
else
  echo This is a regular PR;
fi
echo "${CIRCLE_PULL_REQUEST##https://github.com/FeatureLabs/evalml/pull/}"
This is a regular PR
1172

Test for dependency: #1171

#!/bin/sh -eo pipefail
if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then
  echo This is a release PR;
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
  echo This is a dependency update PR;
else
  echo This is a regular PR;
fi
echo "${CIRCLE_PULL_REQUEST##https://github.com/FeatureLabs/evalml/pull/}"
This is a dependency update PR
1171

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1172 into main will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
+ Coverage   99.72%   99.91%   +0.18%     
==========================================
  Files         197      197              
  Lines       11705    11705              
==========================================
+ Hits        11673    11695      +22     
+ Misses         32       10      -22     
Impacted Files Coverage Δ
...lml/tests/model_understanding_tests/test_graphs.py 100.00% <0.00%> (+0.16%) ⬆️
evalml/automl/automl_search.py 99.58% <0.00%> (+0.41%) ⬆️
.../automl_tests/test_automl_search_classification.py 100.00% <0.00%> (+0.45%) ⬆️
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.74%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <0.00%> (+0.88%) ⬆️
...ests/automl_tests/test_automl_search_regression.py 100.00% <0.00%> (+1.06%) ⬆️
evalml/utils/gen_utils.py 98.94% <0.00%> (+2.10%) ⬆️
evalml/tests/component_tests/test_utils.py 100.00% <0.00%> (+3.57%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51941c1...7d9d37d. Read the comment docs.

Copy link
Collaborator

@dsherry dsherry left a comment

@jeremyliweishih nice, if this works when you test it, I'm on board. Weird that the old pattern just stopped working. Did the dep update branching pattern change?

@@ -193,8 +193,8 @@ jobs:
- run: | # debugging info
if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then
echo This is a release PR;
elif [[ "${CIRCLE_BRANCH}" = "dep-update*" ]]; then
echo This is a depedency update PR;
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
Copy link
Collaborator

@dsherry dsherry Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use dep-update-.* instead? Doesn't really matter what's after the prefix, right?

Copy link
Contributor Author

@jeremyliweishih jeremyliweishih Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherry I'm not too sure why it stopped working and I don't think branching pattern changed. I tried using -.* as my first choice in earlier tries and I couldn't get it to work with the actual dep-update branches. No clue why though..

elif [[ "${CIRCLE_BRANCH}" = "dep-update*" ]]; then
echo This is a depedency update PR;
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
echo This is a dependency update PR;
Copy link
Contributor

@angela97lin angela97lin Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LOL

Copy link
Contributor

@angela97lin angela97lin left a comment

Oo nice, glad you got this to work!

@jeremyliweishih jeremyliweishih merged commit a6470d1 into main Sep 15, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the js_1148_rl branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest dependencies GitHub action fails release notes check
3 participants