-
Notifications
You must be signed in to change notification settings - Fork 89
Fix release notes check for dependency updates PR #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
+ Coverage 99.72% 99.91% +0.18%
==========================================
Files 197 197
Lines 11705 11705
==========================================
+ Hits 11673 11695 +22
+ Misses 32 10 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremyliweishih nice, if this works when you test it, I'm on board. Weird that the old pattern just stopped working. Did the dep update branching pattern change?
@@ -193,8 +193,8 @@ jobs: | |||
- run: | # debugging info | |||
if [[ $(expr match "${CIRCLE_BRANCH}" "release_v[0-9.]\+") -gt 0 ]]; then | |||
echo This is a release PR; | |||
elif [[ "${CIRCLE_BRANCH}" = "dep-update*" ]]; then | |||
echo This is a depedency update PR; | |||
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use dep-update-.*
instead? Doesn't really matter what's after the prefix, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsherry I'm not too sure why it stopped working and I don't think branching pattern changed. I tried using -.*
as my first choice in earlier tries and I couldn't get it to work with the actual dep-update
branches. No clue why though..
elif [[ "${CIRCLE_BRANCH}" = "dep-update*" ]]; then | ||
echo This is a depedency update PR; | ||
elif [[ $(expr match "${CIRCLE_BRANCH}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then | ||
echo This is a dependency update PR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oo nice, glad you got this to work!
Fixes #1148.
This PR:
Test for dependency: #1171