Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_feature_names on OneHotEncoder #1193

Merged
merged 7 commits into from Sep 18, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 17, 2020

Closes #1183

Questions:

@angela97lin angela97lin added this to the September 2020 milestone Sep 17, 2020
@angela97lin angela97lin self-assigned this Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #1193 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       11978    11987    +9     
=======================================
+ Hits        11969    11978    +9     
  Misses          9        9           
Impacted Files Coverage Δ
...components/transformers/encoders/onehot_encoder.py 100.00% <100.00%> (ø)
...alml/tests/component_tests/test_one_hot_encoder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9330de...0e3540b. Read the comment docs.

Copy link
Collaborator

@dsherry dsherry left a comment

@angela97lin looks great!

I wonder if we'll eventually want to adapt get_feature_names to be defined in Transformer. So that we can access the names of features generated by any component.

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 18, 2020

@dsherry Yeah, I could see something like that for the Transformer method too in the future. We already have input_feature_names on the pipelines, and getting the output could also be useful.

@angela97lin angela97lin merged commit 94af4f0 into main Sep 18, 2020
@angela97lin angela97lin deleted the 1183_get_feature_names branch Sep 18, 2020
This was referenced Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose get_feature_names on OneHotEncoder
3 participants