Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DecisionTreeClassifier and DecisionTreeRegressor to AutoML #1255

Merged
merged 4 commits into from Oct 7, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Oct 1, 2020

@angela97lin angela97lin added this to the October 2020 milestone Oct 1, 2020
@angela97lin angela97lin self-assigned this Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1255 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         208      208           
  Lines       13211    13211           
=======================================
  Hits        13203    13203           
  Misses          8        8           
Impacted Files Coverage Δ
evalml/utils/gen_utils.py 100.00% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081806a...80efa3e. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review October 5, 2020 18:13
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin I think this looks great! I left a comment on the performance tests explaining why I think it's ok to add these estimators to search.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☘️

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

dsherry
dsherry approved these changes Oct 7, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin awesome!!! Love the analysis here.

I'd like to understand a bit more about what those 4 outlier datasets were in the validation accuracy graph. That said, I'd be shocked if those had anything to do with decision trees -- I suspect a bug with looking glass, or possibly a bug with automl. So, no need to hold merge for that. But let's discuss.

@angela97lin angela97lin merged commit a5ca749 into main Oct 7, 2020
2 checks passed
@angela97lin angela97lin deleted the 1236_decisiontree_automl branch October 7, 2020 22:13
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DecisionTreeClassifier and DecisionTreeRegressor to AutoML
5 participants