-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DecisionTreeClassifier and DecisionTreeRegressor to AutoML #1255
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 208 208
Lines 13211 13211
=======================================
Hits 13203 13203
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin I think this looks great! I left a comment on the performance tests explaining why I think it's ok to add these estimators to search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☘️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin awesome!!! Love the analysis here.
I'd like to understand a bit more about what those 4 outlier datasets were in the validation accuracy graph. That said, I'd be shocked if those had anything to do with decision trees -- I suspect a bug with looking glass, or possibly a bug with automl. So, no need to hold merge for that. But let's discuss.
Closes #1236
Quip doc here: https://alteryx.quip.com/u5KjAUW92aeS/Adding-DecisionTree-Estimators-in-EvalML