Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Footer to Documentation #1312

Merged
merged 7 commits into from Oct 20, 2020
Merged

Add Footer to Documentation #1312

merged 7 commits into from Oct 20, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Oct 16, 2020

@gsheni gsheni self-assigned this Oct 16, 2020
@gsheni gsheni closed this Oct 19, 2020
@dsherry dsherry reopened this Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1312 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         213      213           
  Lines       13357    13357           
=======================================
  Hits        13349    13349           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f301845...df91116. Read the comment docs.

'issue': ('https://github.com/alteryx/evalml/issues/%s', '#'),
'pr': ('https://github.com/alteryx/evalml/pull/%s', '#'),
'user': ('https://github.com/%s', '@')
"github_url": "https://github.com/FeatureLabs/compose#readme",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this, should be evalml

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsheni thank you for putting this up!

Weird IDK why the jobs didn't run for you earlier. That does happen occasionally, I've noticed. I made a trivial change and force-pushed and it re-triggered them.

I pushed one URL fix, and we should check the docs again once they're done building. Otherwise looks good!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

image

@gsheni gsheni merged commit dec69b1 into main Oct 20, 2020
2 checks passed
@gsheni gsheni deleted the add_footer branch October 20, 2020 13:33
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Alteryx footer to EvalML documentation page
4 participants