Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring for feature_importance #1353

Merged
merged 9 commits into from
Oct 27, 2020
Merged

Fix docstring for feature_importance #1353

merged 9 commits into from
Oct 27, 2020

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Oct 27, 2020 •
edited
Loading

fix #1213

Example of original docs here and fixed docs here

@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #1353 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13632    13632           
=======================================
  Hits        13625    13625           
  Misses          7        7
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 100.00% <ø> (ø)
evalml/utils/base_meta.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397d734...34e34fa. Read the comment docs.

@bchen1116 bchen1116 self-assigned this Oct 27, 2020
@bchen1116 bchen1116 marked this pull request as ready for review October 27, 2020 21:01
dsherry
dsherry approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! Great hunting :D

evalml/utils/base_meta.py Show resolved Hide resolved
freddyaboulton
freddyaboulton approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 Great fix!

@bchen1116 bchen1116 merged commit d757545 into main Oct 27, 2020
@dsherry dsherry mentioned this pull request Oct 29, 2020
Merged
@freddyaboulton freddyaboulton deleted the bc_1213_docstring branch May 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@dsherry dsherry dsherry approved these changes

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@bchen1116 bchen1116

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring for pipeline.feature_importance is incorrect
3 participants
@bchen1116 @dsherry @freddyaboulton