Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda build: use the correct DockerHub credentials #1363

Merged
merged 3 commits into from Oct 29, 2020
Merged

Fix conda build: use the correct DockerHub credentials #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eaf48f
Update config.yml
gsheni Oct 29, 2020
4af6529
Merge branch 'main' into update_conda_docker_credentials
gsheni Oct 29, 2020
e49d40d
Update release_notes.rst
gsheni Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ commands:
cp -r `ls -A | grep -v "evalml-core-feedstock"` ./evalml-core-feedstock/evalml/
python .circleci/conda_config.py "$(python setup.py --version)"
cd evalml-core-feedstock
echo "$DOCKER_HUB_PASS" | docker login -u psalter --password-stdin
echo "$DOCKERHUB_PASSWORD" | docker login -u $DOCKERHUB_USERNAME --password-stdin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 omg I completely missed this yesterday. Thank you!

export DOCKER_CONTAINERID="$(docker run -td condaforge/linux-anvil-comp7)"
echo "Created container ${DOCKER_CONTAINERID}"
chmod -R 777 ./
Expand Down
2 changes: 1 addition & 1 deletion docs/source/release_notes.rst
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@ Release Notes
* Removed code that was lacking codecov for ``__main__.py`` and unnecessary :pr:`1293`
* Codecov: round coverage up instead of down :pr:`1334`
* Add DockerHub credentials to CI testing environment :pr:`1356`

* Add DockerHub credentials to conda testing environment :pr:`1363`

.. warning::

Expand Down