Removing category_encoders from test-requirements.txt#1373
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 91.21% 99.95% +8.75%
==========================================
Files 213 213
Lines 13928 13928
==========================================
+ Hits 12703 13921 +1218
+ Misses 1225 7 -1218
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
angela97lin,
bchen1116,
christopherbunn,
dsherry,
eccabay and
jeremyliweishih
jeremyliweishih
approved these changes
Oct 30, 2020
freddyaboulton
force-pushed
the
remove-category-encoders
branch
from
d4cb6ff to
5c9a6f2
Compare
freddyaboulton
force-pushed
the
remove-category-encoders
branch
from
5c9a6f2 to
23d5d2a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In #572, we moved
category-encodersto test-requirements.txt because some unit tests needed it but this is no longer the case! We may need this dependency again in the future when we add new encoders, but we should add it to either core-requirements or requirements when we actually need it.Performance tests here.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.