Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing category_encoders from test-requirements.txt #1373

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Oct 30, 2020

Pull Request Description

In #572, we moved category-encoders to test-requirements.txt because some unit tests needed it but this is no longer the case! We may need this dependency again in the future when we add new encoders, but we should add it to either core-requirements or requirements when we actually need it.

Performance tests here.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #1373 into main will increase coverage by 8.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   91.21%   99.95%   +8.75%     
==========================================
  Files         213      213              
  Lines       13928    13928              
==========================================
+ Hits        12703    13921    +1218     
+ Misses       1225        7    -1218     
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.62% <0.00%> (+0.39%) ⬆️
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+1.11%) ⬆️
...s/prediction_explanations_tests/test_algorithms.py 100.00% <0.00%> (+1.12%) ⬆️
evalml/utils/gen_utils.py 100.00% <0.00%> (+1.53%) ⬆️
evalml/tests/component_tests/test_utils.py 100.00% <0.00%> (+1.86%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <0.00%> (+3.39%) ⬆️
...derstanding/prediction_explanations/_algorithms.py 97.15% <0.00%> (+4.29%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
.../automl_tests/test_automl_search_classification.py 100.00% <0.00%> (+10.45%) ⬆️
...ests/automl_tests/test_automl_search_regression.py 100.00% <0.00%> (+13.37%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b106a...23d5d2a. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thanks!

@freddyaboulton freddyaboulton marked this pull request as ready for review October 30, 2020 17:04
@freddyaboulton freddyaboulton force-pushed the remove-category-encoders branch from d4cb6ff to 5c9a6f2 Compare October 30, 2020 20:15
@freddyaboulton freddyaboulton force-pushed the remove-category-encoders branch from 5c9a6f2 to 23d5d2a Compare October 30, 2020 20:21
@freddyaboulton freddyaboulton merged commit 5d3cba8 into main Oct 30, 2020
@freddyaboulton freddyaboulton deleted the remove-category-encoders branch October 30, 2020 20:39
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants