New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Updated _evaluate_pipelines to consolidate side effects" #1409
Conversation
This reverts commit 9451546.
Yep, due to the test flake from #1408 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christopherbunn !
@christopherbunn for the release notes, I'd say you can just append "reverted :pr:`1409`" to the end. Then when we fix and re-merge, we can delete that entry and replace with the new one. That work? |
Codecov Report
@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 91.21% 99.95% +8.75%
==========================================
Files 213 213
Lines 13934 13938 +4
==========================================
+ Hits 12708 13931 +1223
+ Misses 1226 7 -1219
Continue to review full report at Codecov.
|
@dsherry Since the changelog line for 1337 isn't there anymore with this revert PR, I think I'll just make a new entry for now. We can delete when we push it back in. |
@@ -8,6 +8,7 @@ Release Notes | |||
* Fixes | |||
* Updated enum classes to show possible enum values as attributes :pr:`1391` | |||
* Changes | |||
* Reverted changes from :pr:`1337` :pr:`1409` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverts #1337