Revert "Updated _evaluate_pipelines to consolidate side effects"

[christopherbunn]

Reverts #1337

[dsherry]

Yep, due to the test flake from #1408

[dsherry]

👍

[freddyaboulton]

Thanks @christopherbunn ! 👍

[dsherry]

@christopherbunn for the release notes, I'd say you can just append "reverted :pr:`1409`" to the end. Then when we fix and re-merge, we can delete that entry and replace with the new one. That work?

[codecov]

Codecov Report

Merging #1409 into main will increase coverage by 8.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   91.21%   99.95%   +8.75%     
==========================================
  Files         213      213              
  Lines       13934    13938       +4     
==========================================
+ Hits        12708    13931    +1223     
+ Misses       1226        7    -1219     

Impacted Files	Coverage Δ
evalml/automl/automl_search.py	99.62% <100.00%> (+0.58%)	⬆️
evalml/tests/automl_tests/test_automl.py	100.00% <100.00%> (ø)
evalml/utils/logger.py	100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py	100.00% <0.00%> (+1.11%)	⬆️
...s/prediction_explanations_tests/test_algorithms.py	100.00% <0.00%> (+1.12%)	⬆️
evalml/utils/gen_utils.py	100.00% <0.00%> (+1.53%)	⬆️
evalml/tests/component_tests/test_utils.py	100.00% <0.00%> (+1.86%)	⬆️
evalml/tests/pipeline_tests/test_pipelines.py	100.00% <0.00%> (+3.39%)	⬆️
...derstanding/prediction_explanations/_algorithms.py	97.15% <0.00%> (+4.29%)	⬆️
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9451546...cf8010c. Read the comment docs.

[christopherbunn]

@christopherbunn for the release notes, I'd say you can just append "reverted :pr:1409" to the end. Then when we fix and re-merge, we can delete that entry and replace with the new one. That work?

@dsherry Since the changelog line for 1337 isn't there anymore with this revert PR, I think I'll just make a new entry for now. We can delete when we push it back in.

[dsherry]

👍 cool, yep we can delete this when we merge a new PR