You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There currently is no implementation for adding additional nodes or adding two graphs together, as mentioned in the original issue, is there? Not sure if I missed something, but might be nice to file an issue to track adding those two!
Great point @bchen1116! I did remove these capabilities as I iterated through this PR. With the decision for the ComponentGraph class to be completely internal/private (users shouldn't ever need to muck with it), any use cases for adding nodes or merging graphs disappeared. That being said, it may be worth it to file another issue to track adding that in the future, should use cases arise. (This PR is already so large, that work would probably be left to a separate issue)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.