Skip to content

Update dependency check with new version #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Update dependency check with new version #1443

merged 2 commits into from
Nov 16, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Nov 16, 2020

No description provided.

@gsheni gsheni requested a review from dsherry November 16, 2020 22:25
@gsheni gsheni self-assigned this Nov 16, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@gsheni gsheni changed the title Update dependency_check.yml Update dependency check with new version Nov 16, 2020
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gsheni !! 🎉

Yep, the action just started failing 30min ago with a "set-env" message:

The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

The fix is to update the version of the create-pull-request action we use. We updated our fork to include v3

with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: Update latest dependencies
title: Automated Latest Dependency Updates
author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, so this just makes it so the author stays as "github-actions[bot]". Awesome

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1443 (c5339c2) into main (ea6584d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         220      220           
  Lines       14582    14582           
=======================================
  Hits        14575    14575           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6584d...c5339c2. Read the comment docs.

@gsheni gsheni merged commit 3ae99d2 into main Nov 16, 2020
@gsheni gsheni deleted the update_pr_action branch November 16, 2020 22:42
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants