New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copy_dataframe
parameter, update requirements with release of Woodwork v0.0.6
#1478
Changes from all commits
bdddd95
fc36f18
91bbbc1
5cbd658
ffbf3b0
038cf38
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -300,9 +300,11 @@ def _convert_to_woodwork_structure(data): | |
ww_data = pd.DataFrame(ww_data) | ||
|
||
# Convert pandas data structures to Woodwork data structures | ||
ww_data = ww_data.copy() | ||
if isinstance(ww_data, pd.Series): | ||
return ww.DataColumn(ww_data) | ||
return ww.DataTable(ww_data, copy_dataframe=True) | ||
|
||
return ww.DataTable(ww_data) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, so is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. EDIT: Oops, didn't read your comment thoroughly. It doesn't copies implicitly. See description for alteryx/woodwork#398! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @angela97lin ! Filed alteryx/woodwork#420 |
||
|
||
|
||
def _convert_woodwork_types_wrapper(pd_data): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WholeNumber was removed