-
Notifications
You must be signed in to change notification settings - Fork 89
Update allow list for deps update bot #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf6ce9e
to
9a39948
Compare
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15025 15025
=======================================
Hits 15018 15018
Misses 7 7 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😁 Will be useful to use everything from core-requirements.txt, but hopefully doesn't trigger toooo often?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsherry This looks great! Does updating the circle-ci check update the github dependency bot? (I don't really know how it works hehe).
I have a question about the grep but it's mainly just for my understanding.
@@ -0,0 +1,3 @@ | |||
allow_list=$(cat core-requirements.txt requirements.txt | grep -oE "^[a-zA-Z0-9\-_]+" | paste -d "|" -s -) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddyaboulton yes because we're using grep -E
which uses a regex, and "scikit" will match both sklearn and skopt.
@freddyaboulton the updates to the bot are under the changes to |
@jeremyliweishih Thanks! I get it now 😅 |
Include woodwork, featuretools etc.