Update allow list for deps update bot #1480
Conversation
dsherry
force-pushed
the
ds_update_deps_bot_allow_list
branch
from
bf6ce9e
to
9a39948
Compare
dsherry
requested review from
jeremyliweishih,
freddyaboulton and
angela97lin
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15025 15025
=======================================
Hits 15018 15018
Misses 7 7 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@dsherry This looks great! Does updating the circle-ci check update the github dependency bot? (I don't really know how it works hehe).
I have a question about the grep but it's mainly just for my understanding.
| @@ -0,0 +1,3 @@ | |||
| allow_list=$(cat core-requirements.txt requirements.txt | grep -oE "^[a-zA-Z0-9\-_]+" | paste -d "|" -s -) | |||
There was a problem hiding this comment.
The grep picks up both scikit-learn and scikit-optimize as just "scikit". Is that ok?
There was a problem hiding this comment.
@freddyaboulton yes because we're using grep -E which uses a regex, and "scikit" will match both sklearn and skopt.
|
@freddyaboulton the updates to the bot are under the changes to |
|
@jeremyliweishih Thanks! I get it now |
Include woodwork, featuretools etc.