Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin woodwork version #1484

Merged
merged 2 commits into from Dec 1, 2020
Merged

Pin woodwork version #1484

merged 2 commits into from Dec 1, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Dec 1, 2020

In order to avoid breaking changes (#1478 ), let's pin the woodwork version in each evalml release, so that pip install evalml always produces a working installation.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sounds good 👍 This'll help @jeff-hernandez too, who was running into this issue a couple of times!

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1484 (4e6a770) into main (d94397f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         223      223           
  Lines       15100    15100           
=======================================
  Hits        15093    15093           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94397f...4e6a770. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dsherry !

@dsherry dsherry merged commit 58c56a0 into main Dec 1, 2020
@dsherry dsherry mentioned this pull request Dec 1, 2020
@freddyaboulton freddyaboulton deleted the ds_pin_woodwork branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants