Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have circleci badge filtered to main branch, not latest build #1489

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Dec 1, 2020

I noticed when some branch was failing, the circleci badge showed up red
Screen Shot 2020-12-01 at 6 35 50 PM

That's because it applies to all builds and isn't filtered to main. This PR fixes that (I hope!)

@dsherry dsherry added the enhancement An improvement to an existing feature. label Dec 1, 2020
@dsherry dsherry force-pushed the ds_circleci_badge_filter branch from c6a9354 to a15e95e Compare December 1, 2020 23:43
@dsherry dsherry marked this pull request as ready for review December 1, 2020 23:47
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1489 (a1fcdac) into main (3d69967) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         223      223           
  Lines       15139    15139           
=======================================
  Hits        15132    15132           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d69967...a1fcdac. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I've noticed this too. Thanks, this looks good! 😁

@dsherry dsherry merged commit b49e2fc into main Dec 2, 2020
@dsherry dsherry deleted the ds_circleci_badge_filter branch December 2, 2020 20:27
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants