Have circleci badge filtered to main branch, not latest build#1489
Merged
Conversation
dsherry
force-pushed
the
ds_circleci_badge_filter
branch
from
December 1, 2020 23:43
c6a9354 to
a15e95e
Compare
dsherry
marked this pull request as ready for review
December 1, 2020 23:47
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15139 15139
=======================================
Hits 15132 15132
Misses 7 7 Continue to review full report at Codecov.
|
angela97lin
approved these changes
Dec 2, 2020
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Ah, I've noticed this too. Thanks, this looks good! 😁
jeremyliweishih
approved these changes
Dec 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when some branch was failing, the circleci badge showed up red
That's because it applies to all builds and isn't filtered to
main. This PR fixes that (I hope!)