Fix windows unit test CI #1490
Merged
Fix windows unit test CI #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
commented
Dec 2, 2020
| @@ -1,7 +1,7 @@ | |||
| version: 2.1 | |||
|
|
|||
| orbs: | |||
| windows: circleci/windows@2.2.0 | |||
| windows: circleci/windows@2.4.0 | |||
There was a problem hiding this comment.
This wasn't needed for this PR, I just figured we should use latest.
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 223 223
Lines 15100 15100
=======================================
Hits 15093 15093
Misses 7 7 Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
@dsherry Thanks for the fix! The docs change looks great to me.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @freddyaboulton for the tips in slack! He mentioned:
My suggested fix: install
numbausing conda, and mention this on the install page in the "Windows" section.