Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom index bug in get_prediction_vs_actual_over_time_data #1494

Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

After merging #1483 I realized that get_prediction_vs_actual_over_time_data does not support a custom index! This fixes that.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #1494 (c146174) into main (7f63094) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1494     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         223      223             
  Lines       15257    15262      +5     
=========================================
+ Hits        15250    15255      +5     
  Misses          7        7             
Impacted Files Coverage Δ
evalml/model_understanding/graphs.py 100.0% <100.0%> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f63094...c146174. Read the comment docs.

@freddyaboulton freddyaboulton changed the title Resetting index and updating test. Fix custom index bug in get_prediction_vs_actual_over_time_data Dec 2, 2020
@freddyaboulton freddyaboulton marked this pull request as ready for review December 2, 2020 20:57
@freddyaboulton freddyaboulton self-assigned this Dec 2, 2020
@freddyaboulton freddyaboulton added the bug Issues tracking problems with existing features. label Dec 2, 2020
@freddyaboulton freddyaboulton added this to the December 2020 milestone Dec 2, 2020
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one suggestion on the impl

@@ -561,25 +561,28 @@ def get_prediction_vs_actual_over_time_data(pipeline, X, y, dates):
"""Get the data needed for the prediction_vs_actual_over_time plot.

Arguments:
pipeline (PipelineBase): Fitted time series regression pipeline.
pipeline (TimeSeriesRegressionPipeline): Fitted time series regression pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good call!

evalml/model_understanding/graphs.py Show resolved Hide resolved
@freddyaboulton freddyaboulton force-pushed the reset-index-get_prediction_vs_actual_over_time_data branch from b005329 to c6a265e Compare December 2, 2020 22:38
@freddyaboulton freddyaboulton force-pushed the reset-index-get_prediction_vs_actual_over_time_data branch from c6a265e to c146174 Compare December 3, 2020 21:07
@freddyaboulton freddyaboulton merged commit c51ce24 into main Dec 3, 2020
@freddyaboulton freddyaboulton deleted the reset-index-get_prediction_vs_actual_over_time_data branch December 3, 2020 21:54
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues tracking problems with existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants