Skip to content

Provide more information to users about ensembling behavior#1527

Merged
angela97lin merged 11 commits intomainfrom
1461_ensembling_info
Dec 14, 2020
Merged

Provide more information to users about ensembling behavior#1527
angela97lin merged 11 commits intomainfrom
1461_ensembling_info

Conversation

@angela97lin
Copy link
Contributor

Closes #1461

@angela97lin angela97lin added this to the December 2020 milestone Dec 8, 2020
@angela97lin angela97lin self-assigned this Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #1527 (e2e8c7b) into main (3698425) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1527     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         234      234             
  Lines       16773    16803     +30     
=========================================
+ Hits        16765    16795     +30     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.7% <100.0%> (+0.1%) ⬆️
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3698425...e2e8c7b. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review December 9, 2020 16:24
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks great! I have one minor comment about letting the user know when ensembling will run if they specify a large enough number of iterations instead of batches. I think we only tell them anything if the number of iterations is too small.

I think we should also add coverage for the "Ensembling will run every k batches." message. Maybe in test_max_batches_works ?

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the test @freddyaboulton pointed out. Left one small suggestion, but nothing blocking.

@angela97lin angela97lin merged commit 61e1a62 into main Dec 14, 2020
@angela97lin angela97lin deleted the 1461_ensembling_info branch December 14, 2020 23:23
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide more information to users about ensembling behavior

3 participants