Provide more information to users about ensembling behavior#1527
Provide more information to users about ensembling behavior#1527angela97lin merged 11 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1527 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 234 234
Lines 16773 16803 +30
=========================================
+ Hits 16765 16795 +30
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin Looks great! I have one minor comment about letting the user know when ensembling will run if they specify a large enough number of iterations instead of batches. I think we only tell them anything if the number of iterations is too small.
I think we should also add coverage for the "Ensembling will run every k batches." message. Maybe in test_max_batches_works ?
bchen1116
left a comment
There was a problem hiding this comment.
Looks good to me. I like the test @freddyaboulton pointed out. Left one small suggestion, but nothing blocking.
Closes #1461