Repository navigation
Move JSON check to CodeGen rather than as helper function - #1531
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 230 230
Lines 15824 15831 +7
=========================================
+ Hits 15816 15823 +7
Misses 8 8
Continue to review full report at Codecov.
|
Contributor
|
@bchen1116 did you mean to put this in Review instead of In Progress? I see there are test failures so unsure if its ready for review |
Contributor
Author
|
@dsherry it's In Progress for me, but I'll fix these tests and get it up for review soon |
bchen1116
marked this pull request as draft
December 9, 2020 16:40
bchen1116
marked this pull request as ready for review
December 9, 2020 17:32
bchen1116
requested review from
ParthivNaresh,
angela97lin,
christopherbunn,
dsherry,
eccabay,
freddyaboulton and
jeremyliweishih
and removed request for
dsherry
December 9, 2020 17:32
jeremyliweishih
approved these changes
Dec 9, 2020
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
Is this just to address Dylan's comments? If so, LGTM!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1495
Follow-up on this pr. Moved JSON check to CodeGen function, added additional tests