Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON check to CodeGen rather than as helper function #1531

Merged
merged 4 commits into from Dec 9, 2020

Conversation

bchen1116
Copy link
Contributor

fix #1495

Follow-up on this pr. Moved JSON check to CodeGen function, added additional tests

@bchen1116 bchen1116 self-assigned this Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1531 (de3e243) into main (6aac72d) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1531     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         230      230             
  Lines       15824    15831      +7     
=========================================
+ Hits        15816    15823      +7     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/pipelines/utils.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aac72d...de3e243. Read the comment docs.

@dsherry
Copy link
Contributor

dsherry commented Dec 9, 2020

@bchen1116 did you mean to put this in Review instead of In Progress? I see there are test failures so unsure if its ready for review

@bchen1116
Copy link
Contributor Author

@dsherry it's In Progress for me, but I'll fix these tests and get it up for review soon

@bchen1116 bchen1116 marked this pull request as draft December 9, 2020 16:40
@bchen1116 bchen1116 marked this pull request as ready for review December 9, 2020 17:32
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just to address Dylan's comments? If so, LGTM!

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 looks great!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 👍

@bchen1116 bchen1116 merged commit 06babaa into main Dec 9, 2020
1 check passed
@dsherry dsherry mentioned this pull request Dec 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1495_fix branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code generation can't handle booleans in the parameters dict
4 participants