-
Notifications
You must be signed in to change notification settings - Fork 91
Move JSON check to CodeGen rather than as helper function #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 230 230
Lines 15824 15831 +7
=========================================
+ Hits 15816 15823 +7
Misses 8 8
Continue to review full report at Codecov.
|
@bchen1116 did you mean to put this in Review instead of In Progress? I see there are test failures so unsure if its ready for review |
@dsherry it's In Progress for me, but I'll fix these tests and get it up for review soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just to address Dylan's comments? If so, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! 👍
fix #1495
Follow-up on this pr. Moved JSON check to CodeGen function, added additional tests