Fix dependency issue [Plotly and XGBoost] #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1533 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 230 230
Lines 15824 15824
=======================================
Hits 15816 15816
Misses 8 8 Continue to review full report at Codecov.
|
dsherry
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
@bchen1116 thanks!
Looks like the deps update job failed, and you'll need to update the expected version of plotly in latest_dependency_versions.txt in order to get that to pass in this PR. If you're curious how that check works, here's the code!
bchen1116
requested review from
angela97lin,
freddyaboulton and
jeremyliweishih
dsherry
reviewed
Dec 9, 2020
| @@ -9,7 +9,7 @@ lightgbm==3.1.1 | |||
| nlp-primitives==1.1.0 | |||
| numpy==1.19.4 | |||
| pandas==1.1.5 | |||
| plotly==4.14.0 | |||
| plotly==4.14.1 | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix #1534
Suspect there's an issue with the new version of XGBoost that is causing the error, so we remove the versioning limit on Plotly