Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1535 save graphs to file #1550

Merged
merged 24 commits into from Dec 18, 2020
Merged

1535 save graphs to file #1550

merged 24 commits into from Dec 18, 2020

Conversation

ParthivNaresh
Copy link
Contributor

@ParthivNaresh ParthivNaresh commented Dec 14, 2020 •
edited

Fixes #1535

Allows the user to save an image belonging to plotly.Figure, graphviz.Source, matplotlib.pyplot.Figure, or matplotlib.axes.SubplotBase to their local file system.

@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited

Codecov Report

Merging #1550 (2438181) into main (913919c) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1550     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         239      239             
  Lines       17406    17593    +187     
=========================================
+ Hits        17398    17585    +187     
  Misses          8        8
Impacted Files Coverage Δ
evalml/tests/conftest.py 100.0% <100.0%> (ø)
evalml/tests/utils_tests/test_gen_utils.py 100.0% <100.0%> (ø)
evalml/utils/gen_utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913919c...2438181. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review December 14, 2020 20:25
bchen1116
bchen1116 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few comments on potential ways to clean tests and a suggestion on letting users know when plots are saved under different names.

evalml/tests/utils_tests/test_gen_utils.py Outdated Show resolved Hide resolved
evalml/tests/utils_tests/test_gen_utils.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Show resolved Hide resolved
evalml/tests/utils_tests/test_gen_utils.py Show resolved Hide resolved
evalml/utils/gen_utils.py Show resolved Hide resolved
@ParthivNaresh ParthivNaresh merged commit 22cd574 into main Dec 18, 2020
1 check passed
ParthivNaresh added a commit that referenced this pull request Dec 18, 2020
@ParthivNaresh
Revert "1535 save graphs to file (#1550)"
ea9ef9e 
This reverts commit 22cd574.
@ParthivNaresh ParthivNaresh mentioned this pull request Dec 18, 2020
Merged
ParthivNaresh added a commit that referenced this pull request Dec 18, 2020
@ParthivNaresh
Revert "1535 save graphs to file" (#1585)
7a60a91 
* Revert "1535 save graphs to file (#1550)"

This reverts commit 22cd574.

* release notes
@dsherry dsherry mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchen1116 bchen1116 bchen1116 approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@angela97lin angela97lin Awaiting requested review from angela97lin

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

Assignees

@ParthivNaresh ParthivNaresh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model understanding: save graphs to file
2 participants
@ParthivNaresh @bchen1116