1535 save graphs to file#1550
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1550 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 239 239
Lines 17406 17593 +187
=========================================
+ Hits 17398 17585 +187
Misses 8 8
Continue to review full report at Codecov.
|
ParthivNaresh
requested review from
angela97lin,
bchen1116,
dsherry,
freddyaboulton and
jeremyliweishih
bchen1116
approved these changes
Dec 16, 2020
bchen1116
left a comment
bchen1116
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Left a few comments on potential ways to clean tests and a suggestion on letting users know when plots are saved under different names.
ParthivNaresh
added a commit
that referenced
this pull request
Dec 18, 2020
This reverts commit 22cd574.
ParthivNaresh
added a commit
that referenced
this pull request
Dec 18, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Allows the user to save an image belonging to plotly.Figure, graphviz.Source, matplotlib.pyplot.Figure, or matplotlib.axes.SubplotBase to their local file system.