Make get_prediction_vs_actual_data() a public method#1553
Conversation
christopherbunn
force-pushed
the
1542_get_prediction_vs_actual_data
branch
from
2a23252 to
9969dd0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1553 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 234 234
Lines 16803 16827 +24
=========================================
+ Hits 16795 16819 +24
Misses 8 8
Continue to review full report at Codecov.
|
christopherbunn
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
dsherry,
eccabay,
freddyaboulton and
jeremyliweishih
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@christopherbunn I think this is good to merge!
| def _get_prediction_vs_actual_data(y_true, y_pred, outlier_threshold): | ||
| """Helper method to help calculate the y_true and y_pred dataframe, with a column for outliers""" | ||
| def get_prediction_vs_actual_data(y_true, y_pred, outlier_threshold=None): | ||
| """Combines y_true and y_pred into a single dataframe and adds a column for outliers. Used in `graph_prediction_vs_actual()`. |
| y_true (pd.Series): The real target values of the data | ||
| y_pred (pd.Series): The predicted values outputted by the regression model. |
There was a problem hiding this comment.
Looks like from impl that woodwork is supported too? Could you update docstr / tests? Otherwise I can wait for this to be merged and add it to a PR of mine too hehe
There was a problem hiding this comment.
Yep I can add it to this PR!
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Looks good to me!! Thanks for this 🥳
|
Looks like one of the windows checks threw an internal pytest error. Since the other two windows checks passed and the particular failed test passed after rerunning I think it's a one-off error. |
christopherbunn
force-pushed
the
1542_get_prediction_vs_actual_data
branch
from
c46fd27 to
dd887eb
Compare
christopherbunn
force-pushed
the
1542_get_prediction_vs_actual_data
branch
from
dd887eb to
8bf755d
Compare
dsherry
left a comment
dsherry
left a comment
There was a problem hiding this comment.
@christopherbunn this is excellent! 🚀
4 participants
Made
get_prediction_vs_actual_data()a public method, added a check foroutlier_threshold, and added it to API documentation.Resolves #1542