Update Woodwork to 0.0.7 #1560
Merged
Update Woodwork to 0.0.7 #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o update_woodwork_0.0.7
Codecov Report
@@ Coverage Diff @@
## main #1560 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 236 236
Lines 16881 16877 -4
=========================================
- Hits 16873 16869 -4
Misses 8 8
Continue to review full report at Codecov.
|
angela97lin
commented
Dec 16, 2020
angela97lin
commented
Dec 16, 2020
| if isinstance(data, list): | ||
| ww_data = np.array(data) | ||
|
|
||
| if isinstance(ww_data, pd.api.extensions.ExtensionArray) or (isinstance(ww_data, np.ndarray) and len(ww_data.shape) == 1): |
Contributor
Author
There was a problem hiding this comment.
Yay, Woodwork update means we can convert directly from numpy now, so no need for this extra logic to convert to pandas first!
angela97lin
requested review from
ParthivNaresh,
bchen1116,
dsherry,
freddyaboulton and
jeremyliweishih
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Woodwork version adds useful functionality, and addresses some issues (alteryx/woodwork#455) so I think it's a worthwhile upgrade 😁