Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woodwork to 0.0.7 #1560

Merged
merged 10 commits into from Dec 16, 2020
Merged

Update Woodwork to 0.0.7 #1560

merged 10 commits into from Dec 16, 2020

Conversation

angela97lin
Copy link
Contributor

Latest Woodwork version adds useful functionality, and addresses some issues (alteryx/woodwork#455) so I think it's a worthwhile upgrade 馃榿

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #1560 (fbd010f) into main (73bff4a) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1560     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         236      236             
  Lines       16881    16877      -4     
=========================================
- Hits        16873    16869      -4     
  Misses          8        8             
Impacted Files Coverage 螖
...ts/data_checks_tests/test_id_columns_data_check.py 100.0% <酶> (酶)
evalml/utils/gen_utils.py 100.0% <100.0%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 73bff4a...fbd010f. Read the comment docs.

@@ -294,15 +294,11 @@ def _convert_to_woodwork_structure(data):
# Convert numpy data structures to pandas data structures
if isinstance(data, list):
ww_data = np.array(data)

if isinstance(ww_data, pd.api.extensions.ExtensionArray) or (isinstance(ww_data, np.ndarray) and len(ww_data.shape) == 1):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, Woodwork update means we can convert directly from numpy now, so no need for this extra logic to convert to pandas first!

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@angela97lin angela97lin merged commit e224159 into main Dec 16, 2020
@angela97lin angela97lin deleted the update_woodwork_0.0.7 branch December 16, 2020 17:00
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants