Adding time series support to make_pipeline#1566
Merged
Merged
Conversation
freddyaboulton
changed the title
freddyaboulton
force-pushed
the
1497-make-pipelines-for-timeseries
branch
from
7e06f6b to
2412677
Compare
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1566 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18177 18207 +30
=========================================
+ Hits 18169 18199 +30
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1497-make-pipelines-for-timeseries
branch
from
2c24f04 to
9be2d81
Compare
freddyaboulton
commented
Dec 17, 2020
|
|
||
| categorical_cols = X.select('category') | ||
| if (add_datetime_featurizer or len(categorical_cols.columns) > 0) and estimator_class not in {CatBoostClassifier, CatBoostRegressor}: | ||
| if len(categorical_cols.columns) > 0 and estimator_class not in {CatBoostClassifier, CatBoostRegressor}: |
Contributor
Author
There was a problem hiding this comment.
DateTimeFeaturizer no longer creates categorical features by default.
freddyaboulton
force-pushed
the
1497-make-pipelines-for-timeseries
branch
from
fdd1a24 to
6d43bf3
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
dsherry,
eccabay and
jeremyliweishih
bchen1116
approved these changes
Dec 18, 2020
| pipeline_class = MulticlassClassificationPipeline | ||
| elif problem_type == ProblemTypes.REGRESSION: | ||
| pipeline_class = RegressionPipeline | ||
| pipeline_class = _get_pipeline_base_class(problem_type) |
freddyaboulton
force-pushed
the
1497-make-pipelines-for-timeseries
branch
2 times, most recently
from
7788eb9 to
4561ca0
Compare
This reverts commit d7e6820.
freddyaboulton
force-pushed
the
1497-make-pipelines-for-timeseries
branch
from
4561ca0 to
77691c7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1497
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.