Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMLSearch: rename "data_split" to "data_splitter" #1569

Merged
merged 3 commits into from Dec 29, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Dec 17, 2020

Came up in #1568 , seemed like a nice clarification to make.

How I made this PR (on mac):

git grep -il "data_split" . | xargs sed -i '' -e "s/data_split/data_splitter/g"
git grep -il "data_splitterter" . | xargs sed -i '' -e "s/data_splitterter/data_splitter/g"

@dsherry dsherry added the refactor Work being done to refactor code. label Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1569 (72575f2) into main (edb6ed6) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1569   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18092    18092           
=======================================
  Hits        18084    18084           
  Misses          8        8           
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.7% <100.0%> (ø)
evalml/automl/utils.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
.../automl_tests/test_automl_search_classification.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb6ed6...72575f2. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review December 18, 2020 16:13
@dsherry dsherry marked this pull request as draft December 29, 2020 16:26
@dsherry dsherry marked this pull request as ready for review December 29, 2020 16:26
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@dsherry dsherry merged commit 095b053 into main Dec 29, 2020
@dsherry dsherry deleted the ds_rename_data_split branch December 29, 2020 17:36
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Work being done to refactor code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants