1521 RMSLE MSLE MAPE Primary Objective#1574
Merged
ParthivNaresh merged 51 commits intomainfrom Jan 6, 2021
Merged
Conversation
# Conflicts: # evalml/data_checks/id_columns_data_check.py
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18287 18390 +103
=========================================
+ Hits 18279 18382 +103
Misses 8 8
Continue to review full report at Codecov.
|
ParthivNaresh
requested review from
angela97lin,
dsherry and
freddyaboulton
and removed request for
dsherry
….com/alteryx/evalml into 1521-RMSLE-MSLE-MAPE-primary-objective
freddyaboulton
approved these changes
Jan 4, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@ParthivNaresh Looks good! I have some small suggestions/comments :)
dsherry
approved these changes
Jan 5, 2021
Contributor
dsherry
left a comment
dsherry
left a comment
There was a problem hiding this comment.
@ParthivNaresh looks great! I left one suggestion and one question about a related issue.
dsherry
reviewed
Jan 5, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1521
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.