Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1521 RMSLE MSLE MAPE Primary Objective #1574

Merged
merged 51 commits into from
Jan 6, 2021

Conversation

ParthivNaresh
Copy link
Contributor

Fixes #1521


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1574 (ff490af) into main (584a00e) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1574     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18287    18390    +103     
=========================================
+ Hits        18279    18382    +103     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/data_checks/data_check.py 100.0% <ø> (ø)
evalml/data_checks/data_checks.py 100.0% <ø> (ø)
evalml/objectives/utils.py 100.0% <ø> (ø)
evalml/automl/automl_search.py 99.7% <100.0%> (ø)
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)
evalml/data_checks/default_data_checks.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <100.0%> (ø)
evalml/objectives/objective_base.py 100.0% <100.0%> (ø)
evalml/objectives/standard_metrics.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 100.0% <100.0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584a00e...ff490af. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review December 28, 2020 15:39
@ParthivNaresh ParthivNaresh requested review from dsherry, freddyaboulton and angela97lin and removed request for dsherry December 28, 2020 17:30
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh Looks good! I have some small suggestions/comments :)

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthivNaresh looks great! I left one suggestion and one question about a related issue.

evalml/data_checks/invalid_targets_data_check.py Outdated Show resolved Hide resolved
@ParthivNaresh ParthivNaresh linked an issue Jan 5, 2021 that may be closed by this pull request
@ParthivNaresh ParthivNaresh merged commit 2cd11f6 into main Jan 6, 2021
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
@freddyaboulton freddyaboulton deleted the 1521-RMSLE-MSLE-MAPE-primary-objective branch May 13, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants