-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1521 RMSLE MSLE MAPE Primary Objective #1574
Conversation
# Conflicts: # evalml/data_checks/id_columns_data_check.py
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18287 18390 +103
=========================================
+ Hits 18279 18382 +103
Misses 8 8
Continue to review full report at Codecov.
|
….com/alteryx/evalml into 1521-RMSLE-MSLE-MAPE-primary-objective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthivNaresh Looks good! I have some small suggestions/comments :)
evalml/tests/data_checks_tests/test_invalid_targets_data_check.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthivNaresh looks great! I left one suggestion and one question about a related issue.
Fixes #1521
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.