Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set random_state arg in Data Splitter #1579

merged 5 commits into from Dec 18, 2020

Set random_state arg in Data Splitter #1579

merged 5 commits into from Dec 18, 2020


Copy link

fix #1471

By passing in an int rather than np.random.RandomState, we can ensure the resulting datasplits are equivalent so that the AutoMLSearch algorithm can accurately compare model performances.

@bchen1116 bchen1116 self-assigned this Dec 18, 2020
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #1579 (8da6a0d) into main (3eb27b8) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1579     +/-   ##
+ Coverage   100.0%   100.0%   +0.1%     
  Files         240      240             
  Lines       18030    18055     +25     
+ Hits        18022    18047     +25     
  Misses          8        8             
Impacted Files Coverage Δ
evalml/automl/ 99.7% <100.0%> (+0.1%) ⬆️
evalml/tests/automl_tests/ 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb27b8...8da6a0d. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review December 18, 2020 16:42
Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@bchen1116 bchen1116 merged commit 583d60c into main Dec 18, 2020
1 check passed
@dsherry dsherry mentioned this pull request Dec 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1471_datasplit branch May 13, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

AutoMLSearch uses slightly different splits for each pipeline
2 participants