Component iteration in pipelines #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 242 242
Lines 19075 19143 +68
=========================================
+ Hits 19067 19135 +68
Misses 8 8
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
1571_pipeline_iteration
branch
from
9289ca2 to
a742008
Compare
freddyaboulton
force-pushed
the
1571_pipeline_iteration
branch
from
a742008 to
2d4f2ce
Compare
freddyaboulton
requested review from
christopherbunn,
chukarsten,
jeremyliweishih and
ParthivNaresh
jeremyliweishih
approved these changes
Jan 22, 2021
angela97lin
approved these changes
Jan 22, 2021
| def test_linear_getitem(logistic_regression_binary_pipeline_class): | ||
| pipeline = logistic_regression_binary_pipeline_class({'One Hot Encoder': {'top_n': 4}}) | ||
|
|
||
| assert pipeline[0] == Imputer() |
There was a problem hiding this comment.
Amazing! Just to confirm, giving an invalid index throws... an IndexError? Or ValueError? Just curious since get_component throws a ValueError :p
There was a problem hiding this comment.
Great question, it throws an IndexError!
freddyaboulton
added
refactor
bchen1116
approved these changes
Jan 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1571
Obviously I'm not going to get this in before I leave today, but I had the time so I did what I couldContext since this is an old branch:
This PR addresses a breaking change made in #1543. Prior to #1543, the documented way to iterate through component instances was
[c for c in pipeline.component_graph]. However, #1543 made it so that thecomponent_graphattribute only lists the classes, not the instances. Rather than having users iterate through the private_component_graphattribute, we add a "public" accessor by making the pipelines iterable.This PR accomplishes that by:
__iter__and__next__method to pipelines (as opposed to relying on__getitem__)