Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sklearn version #1594

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Pin sklearn version #1594

merged 2 commits into from
Dec 22, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Dec 22, 2020

Update-deps bot shows that upgrading to sklearn 0.24.0 breaks the stacked ensembler.

#1592 tracks the bugfix which will unblock usage of sklearn 0.24.0. Then #1593 tracks un-capping the sklearn version.

@dsherry dsherry marked this pull request as ready for review December 22, 2020 16:49
@dsherry dsherry added the task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. label Dec 22, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1594 (df1b667) into main (ae1a089) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       17876    17876           
=======================================
  Hits        17862    17862           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1a089...df1b667. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dsherry dsherry merged commit 5993352 into main Dec 22, 2020
@dsherry dsherry deleted the ds_pin_sklearn branch December 22, 2020 17:16
@dsherry dsherry mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants