Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check two examples per class for multiclass in InvalidTargetDataCheck #1596

Merged
merged 6 commits into from
Jan 4, 2021
Merged

Check two examples per class for multiclass in InvalidTargetDataCheck #1596

merged 6 commits into from
Jan 4, 2021

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Dec 22, 2020

@gsheni gsheni self-assigned this Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020 •
edited
Loading

Codecov Report

Merging #1596 (b32bf6a) into main (45f5c44) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1596     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         240      240             
  Lines       18235    18247     +12     
=========================================
+ Hits        18227    18239     +12     
  Misses          8        8
Impacted Files Coverage Δ
evalml/data_checks/data_check_message_code.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <100.0%> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <100.0%> (ø)
...ta_checks_tests/test_invalid_targets_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f5c44...b32bf6a. Read the comment docs.

dsherry
dsherry approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one nit-pick about the error msg

angela97lin
angela97lin suggested changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I left some suggestions on how we could improve the output / clean up the details 👍

@gsheni gsheni force-pushed the 1595_invalid_multiclass_two_examples_per_class branch from f766d84 to 95e5c96 Compare January 4, 2021 18:55
@gsheni gsheni requested a review from angela97lin January 4, 2021 19:04
angela97lin
angela97lin approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates, LGTM! 😁

@gsheni gsheni force-pushed the 1595_invalid_multiclass_two_examples_per_class branch from 8a03ec0 to b32bf6a Compare January 4, 2021 22:50
@gsheni gsheni removed the request for review from freddyaboulton January 4, 2021 23:00
@gsheni gsheni merged commit be22ef8 into main Jan 4, 2021
@gsheni gsheni deleted the 1595_invalid_multiclass_two_examples_per_class branch January 4, 2021 23:29
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@angela97lin angela97lin angela97lin approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidTargetDataCheck does not support checking multiclass
3 participants
@gsheni @dsherry @angela97lin