Check two examples per class for multiclass in InvalidTargetDataCheck - #1596
Merged
Conversation
gsheni
commented
Dec 22, 2020
gsheni
commented
Contributor
- Fixes InvalidTargetDataCheck does not support checking multiclass #1595
Codecov Report
@@ Coverage Diff @@
## main #1596 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 240 240
Lines 18235 18247 +12
=========================================
+ Hits 18227 18239 +12
Misses 8 8
Continue to review full report at Codecov.
|
dsherry
approved these changes
Dec 29, 2020
dsherry
left a comment
dsherry
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Left one nit-pick about the error msg
angela97lin
suggested changes
Dec 29, 2020
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but I left some suggestions on how we could improve the output / clean up the details 👍
gsheni
force-pushed
the
1595_invalid_multiclass_two_examples_per_class
branch
from
January 4, 2021 18:55
f766d84 to
95e5c96
Compare
angela97lin
approved these changes
Jan 4, 2021
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the updates, LGTM! 😁
gsheni
force-pushed
the
1595_invalid_multiclass_two_examples_per_class
branch
from
January 4, 2021 22:50
8a03ec0 to
b32bf6a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.