Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit latest Pandas version #1609

Merged
merged 6 commits into from
Dec 28, 2020
Merged

Omit latest Pandas version #1609

merged 6 commits into from
Dec 28, 2020

Conversation

jeremyliweishih
Copy link
Collaborator

Omit latest Pandas ver

@codecov
Copy link

codecov bot commented Dec 28, 2020 •
edited
Loading

Codecov Report

Merging #1609 (6864265) into main (133b635) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18056    18056           
=======================================
  Hits        18048    18048           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133b635...6864265. Read the comment docs.

@jeremyliweishih jeremyliweishih mentioned this pull request Dec 28, 2020
Closed
dsherry
dsherry approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@dsherry dsherry mentioned this pull request Dec 28, 2020
Closed
dsherry
dsherry approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the new changes look good!

@jeremyliweishih
Copy link
Collaborator Author

@dsherry think I need to specify graphviz version for the circleci tests as well. It's pulling 0.16 as we don't specify any version rn.

https://app.circleci.com/pipelines/github/alteryx/evalml/8385/workflows/7fd82183-536b-458a-b130-cb0696beeae3/jobs/96840/steps

@dsherry
Copy link
Contributor

dsherry commented Dec 28, 2020

@jeremyliweishih yep you beat me to it :) https://github.com/alteryx/evalml/blob/main/.circleci/config.yml#L154

dsherry
dsherry reviewed Dec 28, 2020
View reviewed changes
.circleci/config.yml
@@ -155,7 +155,7 @@ jobs:
command: |
C:\Users\circleci\Miniconda3\shell\condabin\conda-hook.ps1
conda activate curr_py
conda install python-graphviz -q -y
conda install python-graphviz=0.15 -q -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeremyliweishih jeremyliweishih merged commit 7138ec2 into main Dec 28, 2020
@dsherry dsherry mentioned this pull request Dec 29, 2020
Merged
@freddyaboulton freddyaboulton deleted the js_pin_pandas branch May 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

Assignees

@jeremyliweishih jeremyliweishih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyliweishih @dsherry