Skip to content

Omit latest Pandas version#1609

Merged
jeremyliweishih merged 6 commits intomainfrom
js_pin_pandas
Dec 28, 2020
Merged

Omit latest Pandas version#1609
jeremyliweishih merged 6 commits intomainfrom
js_pin_pandas

Conversation

@jeremyliweishih
Copy link
Collaborator

Omit latest Pandas ver

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1609 (6864265) into main (133b635) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18056    18056           
=======================================
  Hits        18048    18048           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133b635...6864265. Read the comment docs.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the new changes look good!

@jeremyliweishih
Copy link
Collaborator Author

@dsherry think I need to specify graphviz version for the circleci tests as well. It's pulling 0.16 as we don't specify any version rn.

https://app.circleci.com/pipelines/github/alteryx/evalml/8385/workflows/7fd82183-536b-458a-b130-cb0696beeae3/jobs/96840/steps

@dsherry
Copy link
Contributor

dsherry commented Dec 28, 2020

C:\Users\circleci\Miniconda3\shell\condabin\conda-hook.ps1
conda activate curr_py
conda install python-graphviz -q -y
conda install python-graphviz=0.15 -q -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeremyliweishih jeremyliweishih merged commit 7138ec2 into main Dec 28, 2020
@dsherry dsherry mentioned this pull request Dec 29, 2020
@freddyaboulton freddyaboulton deleted the js_pin_pandas branch May 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants