Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update load_data to return Woodwork structure and update default parameter value for index to None #1610

Merged
merged 9 commits into from Dec 30, 2020
Merged

Update load_data to return Woodwork structure and update default parameter value for index to None #1610

merged 9 commits into from Dec 30, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #1604, closes #1605

@angela97lin angela97lin self-assigned this Dec 28, 2020
@codecov
Copy link

codecov bot commented Dec 28, 2020 •
edited

Codecov Report

Merging #1610 (b643652) into main (3b56407) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18177    18177           
=======================================
  Hits        18169    18169           
  Misses          8        8
Impacted Files Coverage Δ
evalml/demos/churn.py 100.0% <100.0%> (ø)
evalml/demos/fraud.py 100.0% <100.0%> (ø)
evalml/preprocessing/utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b56407...b643652. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review December 29, 2020 20:00
jeremyliweishih
jeremyliweishih approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

evalml/preprocessing/utils.py Outdated Show resolved Hide resolved
bchen1116
bchen1116 approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@angela97lin angela97lin merged commit 171942e into main Dec 30, 2020
@angela97lin angela97lin deleted the ange_blitz_load_data branch December 30, 2020 21:27
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@angela97lin @jeremyliweishih @bchen1116