Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses stacked ensemble component CV for scikit-learn 0.24 support #1613

merged 5 commits into from Jan 4, 2021


Copy link

@angela97lin angela97lin commented Dec 28, 2020

Helps address support for scikit-learn 0.24 (#1593)

I think this is a change we should make regardless of the interaction between automl and stacking, since a user can still try to create a stacking ensemble pipeline and run into this issue.

@angela97lin angela97lin self-assigned this Dec 28, 2020
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1613 (a2f0f98) into main (635f938) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
  Coverage   100.0%   100.0%           
  Files         240      240           
  Lines       18207    18207           
  Hits        18199    18199           
  Misses          8        8           
Impacted Files Coverage Δ
...lines/components/ensemble/ 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635f938...a2f0f98. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review January 4, 2021 18:59
@angela97lin angela97lin added this to the January 2021 milestone Jan 4, 2021
Copy link

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @angela97lin !

@angela97lin angela97lin merged commit 51d7403 into main Jan 4, 2021
1 check passed
@angela97lin angela97lin deleted the 1592_stacking_bug branch January 4, 2021 20:00
@bchen1116 bchen1116 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants