Skip to content

Addresses stacked ensemble component CV for scikit-learn 0.24 support - #1613

Merged
angela97lin merged 5 commits into
mainfrom
1592_stacking_bug
Jan 4, 2021
Merged

Addresses stacked ensemble component CV for scikit-learn 0.24 support#1613
angela97lin merged 5 commits into
mainfrom
1592_stacking_bug

Conversation

@angela97lin

@angela97lin angela97lin commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Helps address support for scikit-learn 0.24 (#1593)

I think this is a change we should make regardless of the interaction between automl and stacking, since a user can still try to create a stacking ensemble pipeline and run into this issue.

@angela97lin angela97lin self-assigned this Dec 28, 2020
@codecov

codecov Bot commented Dec 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1613 (a2f0f98) into main (635f938) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         240      240           
  Lines       18207    18207           
=======================================
  Hits        18199    18199           
  Misses          8        8           
Impacted Files Coverage Δ
...lines/components/ensemble/stacked_ensemble_base.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635f938...a2f0f98. Read the comment docs.

@angela97lin
angela97lin marked this pull request as ready for review January 4, 2021 18:59
@angela97lin angela97lin added this to the January 2021 milestone Jan 4, 2021

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @angela97lin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants